Ask Your Question
1

Why do the features of pcl_ros decrease

asked 2013-05-04 18:05:35 -0500

s-fujii gravatar image

Hi.

Now we have a mind to rearrange our pcl ros wrappers, jsk_pcl_ros(http: //sourceforge.net/p/jsk-ros-pkg/code/HEAD/tree/trunk/jsk_pcl_ros/), and to send our features to the upstream,https:// github.com/ros-perception/perception_pcl/tree/fuerte-devel/pcl_ros.

But when I see the code of pcl_ros, I feel that the features of the codes are decreasing as the branches of pcl_ros are updated. For example, perception_pcl/pcl_ros/src/{segmentation,surface} are lost. We are also lost about that.

If we send a pull request to bring back the lost features, does ros-perception accept it? And if we send our features to them, does they accept it? What is the policy of maintenance of pcl_ros?

Sorry for my strange English.

Thanks.

edit retag flag offensive close merge delete

1 Answer

Sort by ยป oldest newest most voted
2

answered 2013-05-05 05:03:45 -0500

joq gravatar image

I can't speak for the pcl_ros maintainers, but I expect they would accept a well-implemented push request to reinstate missing features.

To make it easy to merge your changes:

edit flag offensive delete link more

Comments

I appreciate your detailed answer.

But I want to know whether ros-perception really have a will to merge our pull request if it is good.

I want to avoid needless bother.

Thanks.

s-fujii gravatar image s-fujii  ( 2013-05-06 00:25:11 -0500 )edit

Go ahead and open the issue. Explain that you will provide a fix if they are willing to review it and merge if appropriate. You can provide a link to this question.

joq gravatar image joq  ( 2013-05-06 02:17:15 -0500 )edit

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

Stats

Asked: 2013-05-04 18:05:35 -0500

Seen: 95 times

Last updated: May 05 '13