Attention: Answers.ros.org is deprecated as of August the 11th, 2023. Please visit robotics.stackexchange.com to ask a new question. This site will remain online in read-only mode during the transition and into the foreseeable future. Selected questions and answers have been migrated, and redirects have been put in place to direct users to the corresponding questions on Robotics Stack Exchange. Additional details are available here.

Why do the features of pcl_ros decrease

asked 2013-05-04 18:05:35 -0500

s-fujii
11 ●1 ●2 ●2

Hi.

Now we have a mind to rearrange our pcl ros wrappers, jsk_pcl_ros(http: //sourceforge.net/p/jsk-ros-pkg/code/HEAD/tree/trunk/jsk_pcl_ros/), and to send our features to the upstream,https:// github.com/ros-perception/perception_pcl/tree/fuerte-devel/pcl_ros.

But when I see the code of pcl_ros, I feel that the features of the codes are decreasing as the branches of pcl_ros are updated. For example, perception_pcl/pcl_ros/src/{segmentation,surface} are lost. We are also lost about that.

If we send a pull request to bring back the lost features, does ros-perception accept it? And if we send our features to them, does they accept it? What is the policy of maintenance of pcl_ros?

Sorry for my strange English.

Thanks.

edit retag flag offensive close merge delete

add a comment

1 Answer

Sort by » oldest newest most voted

answered 2013-05-05 05:03:45 -0500

joq
25443 ●181 ●256 ●408

I can't speak for the pcl_ros maintainers, but I expect they would accept a well-implemented push request to reinstate missing features.

To make it easy to merge your changes:

open an issue explaining what is being added
fork the ros-perception/perception_pcl repository on github
make your changes
test them
submit a pull request, referring to the relevant issue number

edit flag offensive delete link

Comments

I appreciate your detailed answer.

But I want to know whether ros-perception really have a will to merge our pull request if it is good.

I want to avoid needless bother.

Thanks.

s-fujii ( 2013-05-06 00:25:11 -0500 )edit

Go ahead and open the issue. Explain that you will provide a fix if they are willing to review it and merge if appropriate. You can provide a link to this question.

joq ( 2013-05-06 02:17:15 -0500 )edit

add a comment

Question Tools

Stats

Asked: 2013-05-04 18:05:35 -0500

Seen: 154 times

Last updated: May 05 '13

Why do the features of pcl_ros decrease edit

1 Answer

Comments

Question Tools

Stats

Related questions

Why do the features of pcl_ros decrease