Is object NodeHandle::serviceClient<theService> small?
Dear all,
I'd like to call a service in my main loop. This led me using
NodeHandle::serviceClient<theService>
At the moment I create a new NodeHandle::serviceClient for each service call (ie at each step ~ very often), is that correct practise?
My question relates to how big object NodeHandle::serviceClient is really, because if this is small it is fine to instantiate on the stack at each loop. This question assumes objects theService are small as well.
--- EDIT ---
Although I have an alternative (simply not creating the object at each loop: easy!), I am still interested in knowing whether the class is heavy or not... From reading the source I would say it only contains 3 pointers (so not a big deal to instantiate it in a loop) but maybe there are subtleties I do not understand... Anyone knows about it?
Thanks,
Antoine.
What does 'heavy' mean, and what would be the negative consequences of a 'heavy' object on your application?.
On your source reference: The implementation follows the opaque pointer (PIMPL) idiom. The pointed-to instance containing the implementation details is allocated on the heap.
I admit deciding what is heavy and what is not is up to the specific app. Having a PIMPL (which I had not noticed) makes it heavier though. Things are now clear to me. Thanks for your help!
So what action do you take when you have a 'heavy' object?. I'm just curiously wondering what kind of problems you're running into, or trying to avoid.
I have a vector of services to call in an order changing over time, and I was wondering whether to sort the vector directly or to switch to something like an STL view or maybe a list (I initially wanted to avoid these last two).
Ack. I'd still benchmark the naive implementation just to make sure no premature optimization is taking place.
After this discussion it really appears too risky to move the service objects around (because of potential things happening under the hood, in the PIMPL or in premature optim as you mentioned), so I'll keep it safe and go for a clean STL view or something close... Thanks a lot!