Ask Your Question
3

Is simple action client deprecated? [closed]

asked 2013-01-25 11:05:16 -0500

Dave Coleman gravatar image

updated 2013-01-26 15:35:10 -0500

On Groovy (Ubuntu Precise) I get a depreciated warning when I compile my code with the simple_action_client.h included. I get this message:

/opt/ros/groovy/include/actionlib/client/simple_action_client.h:51:0: warning: "DEPRECATED" redefined [enabled by default]
/opt/ros/groovy/include/octomap/octomap_deprecated.h:7:0: note: this is the location of the previous definition

In that file I find:

#if defined(__GNUC__)
#define DEPRECATED __attribute__((deprecated))
#else
#define DEPRECATED
#endif

Why is simple_action_client.h depreciated? And should I switch to just action_client.h?

Thanks!

edit retag flag offensive reopen merge delete

Closed for the following reason the question is answered, right answer was accepted by Dave Coleman
close date 2013-02-15 13:40:40

2 Answers

Sort by ยป oldest newest most voted
4

answered 2013-01-25 22:52:13 -0500

jbohren gravatar image

First, SimpleActionClient is NOT deprecated.

What you are seeing is a warning about re-defining the macro used to annotate a given function or class is deprecated. It looks like octomap is also defining a macro to use to deprecate code, and they are both called DEPRECATED.

Second, you can see here that the version in octomap checks if DEPRECATED is already defined. The version in simple_action_client.h should also define it in this way.

edit flag offensive delete link more

Comments

1

thanks. i tried to submit a bug report or patch myself just now, but had issues with the old Trac system. i can't wait for everyone to be on github. i emailed one of the maintainers, maybe they can fix this.

Dave Coleman gravatar image Dave Coleman  ( 2013-01-26 15:48:43 -0500 )edit
1

answered 2013-02-15 03:45:43 -0500

Dave Coleman gravatar image

I submitted a patch to Dirk for ActionLib to fix this depreciated warning.

edit flag offensive delete link more

Comments

1

Patch applied.

Dirk Thomas gravatar image Dirk Thomas  ( 2013-02-15 09:14:28 -0500 )edit

Question Tools

2 followers

Stats

Asked: 2013-01-25 11:05:16 -0500

Seen: 201 times

Last updated: Feb 15 '13