Ask Your Question
0

Autoware runtime manager lidar_euclidean_cluster_detect clip_min_height parameter unable to take float values

asked 2020-02-02 21:24:00 -0600

syigzaw gravatar image

In this commit: https://gitlab.com/autowarefoundation... the value of v is changed from -1.3 to -5.

In the Runtime Manager Dialog: https://gitlab.com/autowarefoundation... the way a parameter is determined to be a float instead of an int is by checking whether one of the min, max, or v values is a float. If at least one of them is a float, then it'll be a float param which can receive float values from the user in the dialog box. Before the above commit, this would have worked, but now it's not working and I can't change the clip_min_height value without changing these files manually and rebuilding. In addition, even if I do change these values, they just reset every time I exit the docker container and re-enter. Is there a way to permanently fix these values on my end, or do I need to go in and change them and rebuild every time I re-enter the container?

Either way, I just wanted to let you guys know of this issue. Thanks for your help.

edit retag flag offensive close merge delete

1 Answer

Sort by ยป oldest newest most voted
1

answered 2020-02-11 14:31:18 -0600

Josh Whitley gravatar image

@syigzaw Thanks for looking into the cause of this issue! This sounds like a great opportunity for your first contribution to a major open-source project! As for saving the files while exiting/entering the Docker container, I suggest using the "base" docker container for Autoware (which just has the Linux environment and all dependencies installed) instead of the "full" docker container for Autoware (which also includes the pre-built source code). Here are some instructions which I will add to the Docker section of the Wiki for using the "base" container:

  1. Create a workspace on your machine for working with the code.

    a. cd ~

    b. mkdir -p autoware.ai/src

  2. Clone the Docker repository.

    a. git clone https://gitlab.com/autowarefoundation/autoware.ai/docker

    b. cd docker/generic

  3. Use the run.sh script to enter the base Docker container without Autoware.ai included, mounting the provided folder into the Docker container in the /home/autoware/Autoware folder.

    a. ./run.sh -b $HOME/autoware.ai

  4. Download and build the Autoware.ai source code inside the container.

    a. cd Autoware

    b. wget -O autoware.ai.repos "https://gitlab.com/autowarefoundation/autoware.ai/autoware/raw/master/autoware.ai.repos?inline=false" Note: If you want to use a different version of Autoware than master, replace master in the URL above with the version (e.g. 1.13.0).

    c. vcs import src < autoware.ai.repos

    d. colcon build

After you have completed the above instructions, you will have a workspace on your host machine in $HOME/autoware.ai which has been built by colcon and can be modified without losing your changes. Using the above ./run.sh command will also make that workspace available in the Docker container.

If you want to make a Merge Request to fix this issue, make a fork of the utilities repository on Gitlab. After that, delete the autoware.ai/src/autoware/utilities folder in your workspace, edit autoware.ai.repos to have the utilities repository point to your fork, then run the vcs import command again inside Docker. This will use your fork instead of the official one for the utilities repository. Once you have fixed the file and committed it to your fork, create a merge request back to the Autoware repository and the maintainers will review and merge it!

edit flag offensive delete link more

Comments

Thank you so much for your detailed response. I just submitted a pull request, and I also set up Autoware using the base docker container and it all works perfectly. Thank you so much for your help!

syigzaw gravatar imagesyigzaw ( 2020-02-11 17:50:04 -0600 )edit

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

Stats

Asked: 2020-02-02 21:24:00 -0600

Seen: 26 times

Last updated: Feb 11