Ask Your Question
3

sick drivers don't have diagnostics

asked 2012-03-29 20:47:22 -0600

brice rebsamen gravatar image

I am bit surprised to see that sicktoolbox_wrapper and sick_ldmrs do not provide diagnostics messages. Is it on purpose or is it just by lack of time?

Is there any already implemented diagnostic node for lasers or perhaps a generic diagnostic for sensors that could be added to any driver? For instance, I am planning to write a node that will listen to laser topics and report if the publishing rate is wrong and maybe if the data is all zeros, etc. Or does it exist already?

Or maybe I could modify the sicktoolbox_wrapper code to add these features, but again, was it left out for a reason?

There is no python API for diagnostics_updater, and sick_ldmrs is a python node... so I would have to either implement some manual diagnostic mechanism, or create an extra cpp node to monitor the published messages...

Btw, is the python API on the list of things to do for diagnostics_updater?

Advices would be appreciated.

edit retag flag offensive close merge delete

Comments

1

I wrote a Python API for diagnostic_updater and submitted to the package authors for their inspection. I also wrote a diagnostic for the LDMRS using my python API. I will submit it as well to the package authors, if the python API is accepted.

brice rebsamen gravatar imagebrice rebsamen ( 2012-04-16 22:42:38 -0600 )edit

2 Answers

Sort by ยป oldest newest most voted
2

answered 2012-03-29 21:06:58 -0600

tfoote gravatar image

sicktoolbox_wrapper was written before the diagnostics system was developed. And no one has put the time in to upgrade it. A patch to add support would be appreciated, and would be cleaner than a node which listens to the topic and publishes diagnostics. There's definitely no reason not to do it.

edit flag offensive delete link more

Comments

Hmm... just checked out the code from their SVN repo, and it turns out that chadrockey added a diagnostic publisher on March 11 (r38989). Haven't tested it yet...

brice rebsamen gravatar imagebrice rebsamen ( 2012-03-29 21:38:29 -0600 )edit

That version will probably be released in Fuerte.

joq gravatar imagejoq ( 2012-03-30 02:15:43 -0600 )edit
0

answered 2012-04-01 12:28:35 -0600

Ditto for the sick_ldmrs, it was written before the diagnostics system was developed and we haven't had the time to look into it.

edit flag offensive delete link more

Comments

OK, I took over the maintenance of the diagnostics stack. I added my Python API. I am sending you by email the patch to add diagnostic in sick_ldmrs.

brice rebsamen gravatar imagebrice rebsamen ( 2012-05-09 00:09:24 -0600 )edit

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Question Tools

Stats

Asked: 2012-03-29 20:47:22 -0600

Seen: 217 times

Last updated: Apr 01 '12