rviz_rendering behaves differently in isolated and non-isolated build scenarios
I'm building ros2 from source using this dockerfile. This is outcome of this question. TLDR: the additional packages recommended on the wiki plus ros2:ardent-basic image.
Isolated build complete successfully, but non-isolated builds fail (specifically rviz_rendering fails due to missing RenderSystems/GL/OgreGLPlugin.h). Apart from this package, no other package has such an issue. Ideally, I'd expect the non-isolated build to not fail for missing header files if the isolated build doesn't (as @marguedas pointed it out on this post).
To reproduce, use the docker image and run:
cd
mkdir -p ros2/src
cd ros2
wget https://raw.githubusercontent.com/ros2/ros2/release-latest/ros2.repos
vcs-import src < ros2.repos
src/ament/ament_tools/scripts/ament.py build --build-tests --symlink-install
src/ament/ament_tools/scripts/ament.py build --build-tests --symlink-install --isolated
Asked by kunaltyagi on 2018-06-10 20:25:18 UTC
Answers
I just used two different Docker containers to run the two ament build calls. The result of the first container doing a non-isolated build matches the result of the second container doing an isolated build. Both builds passed without a problem for me.
Asked by Dirk Thomas on 2018-06-12 12:24:00 UTC
Comments
Commit 8595e166d43 solved the issue.
Asked by kunaltyagi on 2018-06-13 03:29:48 UTC
Comments
Please make sure to provide complete steps to reproduce the problem and and that they work. The above has problems with the directories as well as the URL which makes it extra effort for anyone trying to reproduce your problem.
Asked by Dirk Thomas on 2018-06-12 12:23:53 UTC
Sorry about the mess. I've corrected it and am trying to reproduce it again. Those were big brain fade events
Asked by kunaltyagi on 2018-06-12 20:16:05 UTC