Default bool value for test_commits and test_pull_requests in rosdistro format
REP-0143 defines test_commits
and test_pull_requests
(ashamedly I've never noticed these features. Looks so useful!). It's explained in this ticket that while default value of test_commits is false
, ROS buildfarm overrides it as true
. Why is that? Considering this feature is used mainly on ROS distro (correct me if wrong) then doesn't it make more sense to set true
by default (then REP should state so)?
Also, my understanding is that test_pull_requests
is by default false
and remains as false on buildfarm. Why not turn it true? I haven't understood how to trigger the test based on this feature but assuming it's not automatically kicked for every PRs, turning it to true
by default shouldn't harm anything?
Lastly, and most importantly, the usage of these parameters should be documented. In fact I'm willing to contribute, but where's the best location? --> (Update 7/14/2016) It's here.
Yes, I'd be interested in knowing about this as well. I seem to remember @Dirk Thomas giving a rationale once (mailing list, here on Answers, ..), but I can't find it anywhere anymore.